Proposal: Isomorphic pythonVariableRequester and debuggerVariables.ts #10142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #10142 +/- ##
======================================
+ Coverage 55% 61% +5%
======================================
Files 203 203
Lines 9238 9237 -1
Branches 1490 1490
======================================
+ Hits 5099 5636 +537
+ Misses 3737 3126 -611
- Partials 402 475 +73
|
rchiodo
reviewed
May 26, 2022
src/webviews/extension-side/dataviewer/jupyterVariableDataProvider.ts
Outdated
Show resolved
Hide resolved
rchiodo
reviewed
May 26, 2022
rchiodo
reviewed
May 26, 2022
rchiodo
approved these changes
May 26, 2022
sadasant
changed the title
rchiodo
reviewed
May 26, 2022
| @@ -116,7 +119,7 @@ export class DebuggerVariables | |||
| if (this.active) { | |||
| // Note, full variable results isn't necessary for this call. It only really needs the variable value. | |||
| const result = this.lastKnownVariables.find((v) => v.name === name); | |||
| if (result && kernel?.resourceUri?.fsPath.endsWith('.ipynb')) { | |||
| if (result && kernel?.resourceUri?.path.endsWith('.ipynb')) { | |||
There was a problem hiding this comment.
This was part of the existing code already and I don't think that it's much of an issue. But since we have the vscode-path path already I think that path.extname is a safer way to get this.
There was a problem hiding this comment.
I like that! Thank you!
There was a problem hiding this comment.
Aside from that review looks good. Nice work! Approving and you can check out if extpath works here or not.
IanMatthewHuff
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #10092
In this PR, rather than making the
constants.node.tswork with URIs, I'm removing any reference to the root in that file and moving those references to the node file, and I'm also using these on thepythonVariableRequesterto make non-node-specific.How far from the goalpost am I in this PR?
Any feedback appreciated.
If this approach is ok, this might be my last PR before the web variable viewer.
Update: Thanks to the feedback provided now I have also made debuggerVariables isomorphic!